mod_log_config: Add log_formatter support and a JSON log_formatter #429
Conversation
| } | ||
| else { | ||
| if(items[i].tag) { /* or check for constant_item function, don't escape those */ | ||
| lfd->portions[i] = ap_escape_logitem(r->pool, lfd->portions[i]); |
There was a problem hiding this comment.
possibly escaped twice for out-of-tree modules? Do we have to remember if the registration happened via ap_register_log_handler so we don't escape again?
There was a problem hiding this comment.
good point, I'll add another parameter to the new ap_register_log_handler_ex to indicate if the handler does escape the return value.
There was a problem hiding this comment.
MHH, one of the test workflow do fail not sure why. I'll check tomorrow:
https://github.com/thomasmey/httpd/actions/runs/9372712021/
There was a problem hiding this comment.
Hi, I found the bug and did fix the commit and did force push, all tests are green again, please review
thomasmey
force-pushed
the
json-trunk-clean
branch
from
d8bb9d6 to
237c60b
Compare
thomasmey
force-pushed
the
json-trunk-clean
branch
from
237c60b to
753f524
Compare
|
From a casual glance at the pull request, I assume that this does not enable JSON style escaping for ErrorLogFormat. Is this correct? If so, would it be possible to implement that as a followup? |
|
Yes, I think this is correct, but maybe it's not too hard to enhance this functionality to the error log, bigger problem is to get review eye balls and this pr merged.. 🙇 |
|
any progress with the review? |
No description provided.